Add overflow checking for str::get with inclusive ranges
#42428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move any extra logic that the former had into the latter, so they're consistent.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
carols10cents
added
the
S-waiting-on-review
|
Aturon's on vacation this week, sorry this fell through the cracks last week! Let's try... |
|
Let's keep this in the libs team r? @sfackler |
|
@bors r+ |
|
📌 Commit 808a08a has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Jun 13, 2017
Add overflow checking for `str::get` with inclusive ranges Fixes rust-lang#42401 Two commits here: 1. The first makes `str::index` just call `SliceIndex<str>::index`. It's intended to have no behavior change, except where the two methods were inconsistent. 2. The second actually adds the overflow checking to `get(_mut)` (and tests for it)
bors
added a commit
that referenced
this pull request
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42401
Two commits here:
str::indexjust callSliceIndex<str>::index. It's intended to have no behavior change, except where the two methods were inconsistent.get(_mut)(and tests for it)